Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden network management and configuration #170

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Harden network management and configuration #170

merged 1 commit into from
Oct 10, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 8, 2024 •
edited
Loading

Description

Add support for automatic restore on cancellation, retest and harden functionality.

Testing Procedure

Minimal systemdnetwork Jammy image:

  • setting wired DHCP and static
  • setting AP, connecting to it, rebooting, disabling it

Minimal NetworkManager Jammy image:

  • setting wired DHCP and static
  • setting AP, connecting to it, rebooting, disabling it

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included (added / removed hostapd networkd-dispatcher)
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Work in progress Unfinished / work in progress labels Oct 8, 2024
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Scripts labels Oct 8, 2024
@igorpecovnik igorpecovnik force-pushed the netfix branch 26 times, most recently from dd538c1 to e24f0fe Compare October 8, 2024 15:13
@igorpecovnik igorpecovnik force-pushed the netfix branch 20 times, most recently from 9b6a112 to 8b77491 Compare October 9, 2024 16:54
@igorpecovnik igorpecovnik added Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Oct 9, 2024
@igorpecovnik igorpecovnik changed the title Fixing various problems with network configuartion Harden network management and configuration Oct 9, 2024
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Oct 10, 2024
@igorpecovnik igorpecovnik merged commit 9931f1c into main Oct 10, 2024
6 of 26 checks passed
@igorpecovnik igorpecovnik deleted the netfix branch October 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tearran Tearran Tearran approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @Tearran